Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@sormys/choosing winner #52

Merged
merged 9 commits into from
May 21, 2023
Merged

@sormys/choosing winner #52

merged 9 commits into from
May 21, 2023

Conversation

sormys
Copy link
Member

@sormys sormys commented May 21, 2023 •
edited
Loading

  • implemented function to determine winner
  • tests will be added later on

@codecov
Copy link

codecov bot commented May 21, 2023 •
edited
Loading

Codecov Report

Patch coverage: 11.86% and project coverage change: -6.96 ⚠️

Comparison is base (3fce4a7) 89.44% compared to head (af10beb) 82.48%.

❗ Current head af10beb differs from pull request most recent head 9d572e5. Consider uploading reports for the commit 9d572e5 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   89.44%   82.48%   -6.96%     
==========================================
  Files          17       16       -1     
  Lines         663      651      -12     
  Branches       55       60       +5     
==========================================
- Hits          593      537      -56     
- Misses         70      113      +43     
- Partials        0        1       +1
Impacted Files Coverage Δ
src/utils/randomise.ts 20.51% <3.12%> (-79.49%) ⬇️
src/utils/commonRequest.ts 78.50% <22.22%> (-16.60%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mikolaj-pirog mikolaj-pirog merged commit 25b6572 into main May 21, 2023
@sormys sormys deleted the @sormys/choosingWinner branch May 21, 2023 22:03
@sormys sormys linked an issue May 21, 2023 that may be closed by this pull request
Gameplay #10
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwasow Kwasow Kwasow approved these changes

@mikolaj-pirog mikolaj-pirog mikolaj-pirog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gameplay
3 participants
@sormys @Kwasow @mikolaj-pirog